[Stu]

Huntress-Helena Bertinelli, mob daughter trained by mafia assassins to get revenge, turned vigilante, works as a substitute teacher during the day. I really like it because it contrasts her more violent and aggressive tendencies as Huntress (she still struggles a bit with non-lethal means), really positive and not unnecesarilly flashy (like Hal Jordan, who doesn't get enough thrills as an interstellar cop, he needs to show off as an airforce test pilot).
And, btw, there's a bunch of characters I don't know the secret identities of. Like what do Powergirl and Roy Harper do for a living?

[Pun]

I've always liked Spidey's secret identity. I think showing the problems that Peter Parker has shows the readers that being a super hero is not all glitz and glamor.

On the flip side, the worst? Clark fucking Kent! It's Superman in a pair of glasses people! How can that one be so hard to figure out?!?!?

[Batman]

Rorschach as a doomsday-sign-carryin' homeless guy.

[salmonjunkie]

Peter Parker has always been my favorite secret ID. I really liked when JMS made Peter a high school teacher. That was really interesting stuff.

[Lucky]

stu said:

And, btw, there's a bunch of characters I don't know the secret identities of. Like what do Powergirl and Roy Harper do for a living?

Well, Roy started as Speedy, a teenage sidekick and ward to a rich guy. Later I believe he worked as a drug counselor and private detective. Then he became a government operative round about when he took on the Arsenal name. Beyond that? I really don't think he's done or does much other than being a full time adventurer. He's consistently worked with the Titans, Outsiders, or JLA all of whom seem sufficiently well funded and full time. I imagine that there comes sort of stipend or salary with such a gig, and if he and his daughter are living on premises it cuts the cost of living down considerably. I figure that for the folks who become a part of the big, dedicated teams the need for gaineful employment becomes both less as well as the opportunity lessening. And there seem to always be a scientific genius on these teams who you can say "sold some patents" to finance them. Or a rich guy. I'd imagine making it to the Justice League means good benefits.

Powergirl I imagine is in the same boat. As best as I can tell she's spent almost her entire comic book existence as an alien, time traveler, or refuge from a disappeared universe. She's largely been a member of either the JSA or JLE so I imagine there's again some sort of cost of living and salary matter at hand. Didn't she spend much of the last year or so on a foreign planet or in a miniature city in a bottle? She's now the chairman for the JSA, which I presume comes with some sort of salary given the inherrent work and position. And as best as I know she doesn't even have an alter ego but is rather a public figure. She's also worked for Oracle in her Birds of Prey which is most definitely a paying gig.

Spidey and Huntress are masked vigilantes often at odds with the law and rarely with any ties to a legitimate, large corporate like team or organization. So you can understand their greater need for a secret identity and day job.

[Stu]

PG apparently revealed her secret id to the public in the last version of JSA, which basically ended that life, and she's just a Superhero full time.

[Loki]

Greg Rucka's Wonder Woman arc where he actually focused on her as an ambassador.

It wasn't really secret, but it was pretty damn neat in that her "Wonder Woman - costumed hero!" persona would take a back seat in her life to her "Wonder Woman - ambassador from Thymescria whose goal is to promote peace and understanding in the world of men by using America's political system to the best of her advantage". Rucka spent quite a bit of time showing what she did as an ambassador instead of the usual "Oh. She's an ambassador. But we'll never see that, because she needs to fight KHYZDRAK, THE FIVE HEADED MONSTER FROM OUTER SPACE!!!!"